Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assignment not showing in Grade me block #17

Closed
sulaganathan opened this issue Jan 23, 2017 · 47 comments
Closed

Assignment not showing in Grade me block #17

sulaganathan opened this issue Jan 23, 2017 · 47 comments

Comments

@sulaganathan
Copy link

hi,

We are using grade me block 3.1.0.2 on Moodle 3.1 and apparently the assignment which needs grading is not showing on grade me block. Upon further research I found that the query failed to choose the assignment on below condition

SELECT bgm.courseid, bgm.coursename, bgm.itemmodule, bgm.iteminstance, bgm.itemname, bgm.coursemoduleid, bgm.itemsortorder, asgn_sub.id submissionid, asgn_sub.userid, asgn_sub.status FROM mdl_assign_submission asgn_sub JOIN mdl_assign a ON a.id = asgn_sub.assignment LEFT JOIN mdl_block_grade_me bgm ON bgm.courseid = a.course AND bgm.iteminstance = a.id LEFT JOIN mdl_assign_grades ag ON ag.assignment = asgn_sub.assignment AND ag.userid = asgn_sub.userid AND asgn_sub.attemptnumber = ag.attemptnumber WHERE a.grade <> 0 AND (ag.id IS NULL OR asgn_sub.timemodified > ag.timemodified) AND bgm.courseid = 37333 AND bgm.itemmodule = 'assign' and bgm.iteminstance='177990

_asgn_sub.timemodified and ag.timemodified seems to be same date time so that query failed _

ag.timemodified is modified when ran the Moodle cron with the below record

id assignment userid timecreated timemodified grader grade attemptnumber
793 519 12 1485174949 1485174312 2 -1.00000 0

Please check and let us know the workaround
@sulaganathan
Copy link
Author

@jamesmcq Could you please check this

@blakekidney
Copy link

We are experiencing the same issue. The solution seems to be making the comparison a >= rather than just a >.

asgn_sub.timemodified >= ag.timemodified

The idea here is that time the assignment was submitted is greater than the time it was last graded. That way, if a student submits an assignment again after it has been graded, it will show up as needing to be graded again. The two timestamps should never be equal as it would always take longer than a second from the time it was submitted to the time it was graded. So, if the two timestamps are equal, that would indicate they were set systematically which is what I think is happening.

@jamesmcq
Copy link

Hi All - we've added this to our internal work list. I don't have a hard timeline but we expect to tackle it soon. Thanks for the report!

@sulaganathan
Copy link
Author

@jamesmcq any luck on this?

@jamesmcq
Copy link

jamesmcq commented Feb 1, 2017

@sulaganathan Currently scheduled for a developer to work on next week. Should everything go smoothly we'd be looking at release Feb 20th.

@sulaganathan
Copy link
Author

@jamesmcq Might I anticipate newer version on Feb 20th. Please let me know if any delay on this

@sulaganathan
Copy link
Author

@jamesmcq Has the version released? Please kindly let us know

@jamesmcq
Copy link

@sulaganathan We do have a fix for this issue scheduled for release. We're a little behind but will have it available in the next few days.

@wbuk
Copy link

wbuk commented Feb 27, 2017

Please can you let us know when, we are using the very latest version of Moodle and apply the weekly updates to ensure as bug free as possible. Marking is a nightmare, we really need this to allow us to mark all the work easily,

@jamesmcq
Copy link

jamesmcq commented Mar 1, 2017

Hi All, new versions for 2.7, 2.9, 3.0, and 3.1 are now available. Please let me know if this resolves your issues. @wbuk @sulaganathan @blakekidney

@sulaganathan
Copy link
Author

@jamesmcq Thank You so much for the update,

You meant to say we should use this version for Moodle 3.1

https://github.com/remotelearner/moodle-block_grade_me/blob/MOODLE_31_STABLE/version.php

Please confirm?

@sulaganathan
Copy link
Author

@jamesmcq I don't see any new version with release date in recent days, I would request you to share the link of newer version.

@jamesmcq
Copy link

jamesmcq commented Mar 1, 2017

@sulaganathan See https://github.com/remotelearner/moodle-block_grade_me/releases - the first two numbers of the version string correspond to the Moodle version you are using. For example, if you are using Moodle 3.1, choose "v3.1.0.3"

@sulaganathan
Copy link
Author

Thank you so much for the info.

@nickvarney
Copy link

This new patch 'appears' to be intermittently working for us. Using the v3.1.0.3 version on Moodle 3.1.4.
Is the detection of new submissions instantaneous or run via the cron?

@nickvarney
Copy link

nickvarney commented Mar 7, 2017 •
edited

Following my previous post, it's not intermittent, rather the Grade Me block works for an assignment only after we visit the (new style) grading screen for that assignment!?

So when viewing the grading screen URL ending mod/assign/view.php?id=13247&rownum=0&action=grader&userid=1501 and return to the course front page the block springs to life and displays that the assignment needs grading.

@sulaganathan
Copy link
Author

@jamesmcq We are getting failures on test cases, we cant use this code unless all tests passed
grade_me output.txt
. Please look into the attached file and let us know the fixes.

You earlier response is much appreciated.

@sulaganathan
Copy link
Author

@jamesmcq Did you get a chance to look into test failure issue?

@jamesmcq
Copy link

@sulaganathan Other than the unit tests, are you seeing any operational issues?

@sulaganathan
Copy link
Author

Our best practice doesn't allow to use test failures code, so we haven't get chances to check functional/operational yet.

@wbuk
Copy link

wbuk commented Mar 18, 2017

Do we know when a new release version will be available with the fixes are the Versions Tab still says October last year.

@jamesmcq
Copy link

@wbuk Are you looking here? https://github.com/remotelearner/moodle-block_grade_me/releases

@haietza
Copy link

haietza commented Mar 23, 2017

@nickvarney's comment above is what we are seeing as well - you have to visit each individual grading page for it to appear in the block.

@sulaganathan
Copy link
Author

@jamesmcq Did you get a chance to check the test failures issue I had reported earlier? It would be great if you could provide us timeline for this fixes for this issue? I would appreciate your earlier responses here.

https://github.com/remotelearner/moodle-block_grade_me/files/830109/grade_me.output.txt

@sulaganathan
Copy link
Author

Hi @jamesmcq ,

Test failures are blocking us to release the grade me block to client, and the client are really waiting for the fixes for the issue, I am going to fix this test failures on my own and sent you the fixes back to you to incorporate on your future version. Please advise me how you want me to share those fixes By normal php files/ Via github

@nickvarney
Copy link

@sulaganathan Does your version fix the issue that I and @haietza reported above where you have to visit the grading page for the assignment in order for it to show in the block?

Did you also discover this as an issue in your testing?

@wbuk
Copy link

wbuk commented Mar 31, 2017 via email

@sulaganathan
Copy link
Author

@nickvarney , Yes am able to see this,

@sulaganathan
Copy link
Author

@jamesmcq,

There are two issue here

  1. Test cases failures (Attached in earlier message)
  2. Assignment not showing in grade me block, until instructor opens up new grade page.

I fixed both issues, Please let me know If I can take fork of this repository and share my code as pull request

Thanks,
Srini

@jamesmcq
Copy link

jamesmcq commented Apr 3, 2017

Hi All, I've scheduled work to fix both the unit tests and the remaining issues with assignments not showing up.

@sulaganathan if you'd like to submit a pull request to this repository we'll be glad to review it for inclusion.

@wbuk
Copy link

wbuk commented Apr 3, 2017 via email

@sulaganathan
Copy link
Author

sulaganathan commented Apr 3, 2017 •
edited

@jamesmcq,

I have created pull request over here, please check and approve at the earliest,

#18

@gemguardian
Copy link

Hello,
I am facing similar issues as mentioned here. I just wonder when we can expect the pull request being reviewed and with that a new version.

Looking forward to your answer

Gemma

@wbuk
Copy link

wbuk commented Apr 19, 2017 via email

@steve-buss
Copy link

We are finding that clicking the red check mark in front of student's name for a submitted assignment in the Grade Me block takes the user to the old assignment interface without the PDF preview. We are using Moodlerooms 3.1 Maintenance Pack 2.

On our site, click the red check mark in front of the user name for a submitted assignment takes the user to:
http://centralcc2.mrooms.net/mod/assign/view.php?id=1751474&action=grade&rownum=0&useridlistid=17514741492710031
(Screenshot attached)
capture

The actual current assignment grading interface is at:
http://centralcc2.mrooms.net/mod/assign/view.php?id=1751474&action=grader

@wbuk
Copy link

wbuk commented Apr 20, 2017 via email

@gemguardian
Copy link

@jamesmcq I am just wondering if you had time to look at the pull request of sulaganathan.

Since I am facing similar issues as mentioned above and my technical team rather waits for you to fix it, then go on their own. :(

It would be greatly appreciated if you can give a time frame on when you expect a new release with the fixes?

@wbuk
Copy link

wbuk commented May 3, 2017 via email

@Erika06
Copy link

Erika06 commented May 4, 2017

I experienced that issue and change the last line to:

AND (ag.grade IS NULL OR asgn_sub.timemodified >= ag.timemodified)";

Why the original code compares "ag.id IS NULL" ?
The IDs never are null

@wbuk
Copy link

wbuk commented May 4, 2017 via email

@sulaganathan
Copy link
Author

@Erika06 ID null means there would be zero entry on grade table, which means this is not yet graded.

@wbuk
Copy link

wbuk commented May 4, 2017 via email

@jamesmcq
Copy link

jamesmcq commented May 4, 2017

Hi All - don't worry, we haven't forgotten you!

@wbuk
Copy link

wbuk commented May 4, 2017 via email

@jamesmcq
Copy link

@sulaganathan Thanks for submitting this, the change has been released. See my comment in your pull request.

@gemguardian
Copy link

@jamesmcq I am wondering - and maybe I am just miss it - is it correct that the change did not get released towards Moodle.org ?

Thank you

Gemma

@wbuk
Copy link

wbuk commented Jun 6, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@haietza @jamesmcq @nickvarney @blakekidney @sulaganathan @gemguardian @wbuk @steve-buss @Erika06