Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patches for the DSI touchscreen being shifted by 1 pixel #5840

Draft
wants to merge 8 commits into
base: rpi-6.1.y
Choose a base branch
from
Draft

Patches for the DSI touchscreen being shifted by 1 pixel #5840

wants to merge 8 commits into from

Commits on Jan 9, 2024

  1. drm/bridge: tc358762: Add reset GPIO support 

    Add reset GPIO support. The reset GPIO is cleared after supply regulator
was enabled, and set before supply regulator is disabled.

Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230530192805.648646-2-marex@denx.de
    @6by9
    Marek Vasut authored and 6by9 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    3658c6d View commit details
    Browse the repository at this point in the history

  2. drm/bridge: tc358762: Split register programming from pre-enable to e… 

    …nable

Move the register programming part, which actually enables the bridge and
makes it push data out of its DPI side, into the enable callback. The DSI
host like DSIM may not be able to transmit commands in pre_enable, moving
the register programming into enable assures it can transmit commands.

Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230615201902.566182-1-marex@denx.de
    @6by9
    Marek Vasut authored and 6by9 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    aa4bcbb View commit details
    Browse the repository at this point in the history

  3. drm/bridge: tc358762: Switch to atomic ops 

    Switch the bridge driver over to atomic ops. No functional change.

Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230615201902.566182-2-marex@denx.de
    @6by9
    Marek Vasut authored and 6by9 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    09f2f72 View commit details
    Browse the repository at this point in the history

  4. drm/bridge: tc358762: Guess the meaning of LCDCTRL bits 

    The register content and behavior is very similar to TC358764 VP_CTRL.
All the bits except for unknown bit 6 also seem to match, even though
the datasheet is just not available. Add a comment and reuse the bit
definitions.

Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230615201902.566182-4-marex@denx.de
    @6by9
    Marek Vasut authored and 6by9 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    1587a46 View commit details
    Browse the repository at this point in the history

  5. drm/bridge: tc358762: Handle HS/VS polarity 

    Add support for handling the HS/VS sync signals polarity in the bridge
driver, otherwise e.g. DSIM bridge feeds the TC358762 inverted polarity
sync signals and the image is shifted to the left, up, and wobbly.

Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230615201902.566182-5-marex@denx.de
    @6by9
    Marek Vasut authored and 6by9 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    83f7e02 View commit details
    Browse the repository at this point in the history

  6. drm/bridge: tc358762: Program the DPI mode into the chip 

    The autodetection of resolution/timing by the TC358762 can lead
to the display being shifted by a pixel or two.

Program the TC358762 with the requested mode timing so that
it can reproduce it accurately.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
    @6by9
    6by9 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    369bd70 View commit details
    Browse the repository at this point in the history

  7. revert move ops to enable

    @6by9
    6by9 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    cdfb0cc View commit details
    Browse the repository at this point in the history

  8. drm/panel/simple: Correct Pi touchscreen HBP 

    The value was supposedly copied from the firmware via
panel-raspberrypi-touchscreen, but it was copied incorrectly.
The firmware has
but the timings here ended up as just 46.

Correct them to 44.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
    @6by9
    6by9 committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    9781483 View commit details
    Browse the repository at this point in the history