Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncm-metaconfig: Remove caf_service_action type to allow reuse #1335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ncm-metaconfig: Remove caf_service_action type to allow reuse #1335

wants to merge 1 commit into from
+1 −3

Conversation

jrha
Copy link
Member

@jrha jrha commented Oct 25, 2018 •
edited

Requires quattor/template-library-core#191 which moves the type into the core template library.

Enabling work for #1071.

jrha added a commit to jrha/configuration-modules-core that referenced this pull request Oct 25, 2018
@jrha
ncm-network: Add support for CAF::Service actions after changes
ab0d50f 
Largely transcribed from ncm-metaconfig.
Requires quattor#1335.
Resolves quattor#1071.
@jrha jrha mentioned this pull request Oct 25, 2018
Open
@jrha jrha added this to the 18.12 milestone Nov 16, 2018
@jrha jrha modified the milestones: 18.12, 19.2 Dec 10, 2018
@jrha jrha modified the milestones: 19.12, 20.2 Dec 24, 2019
@jrha jrha modified the milestones: 20.3, 20.4 Mar 19, 2020
@stdweird
Copy link
Member

stdweird commented Nov 3, 2020

@jrha @ned21 bit of a mess right now

i propose to keep it simple: close quattor/template-library-core#191, remove any usage of caf_service_action (i.e. keep the current commit) and also switch to caf_serviceaction here.

@ned21
Copy link
Contributor

ned21 commented Nov 3, 2020

i propose to keep it simple: close quattor/template-library-core#191, remove any usage of caf_service_action (i.e. keep the current commit) and also switch to caf_serviceaction here.

Is that fully backwards compatible?

@jrha jrha mentioned this pull request Nov 5, 2020
Closed
@jrha jrha force-pushed the move_caf_service_action branch 2 times, most recently from f42c4f4 to b929c61 Compare December 9, 2022 10:29
@jrha jrha removed this from the 22.12 milestone Dec 23, 2022
jrha added a commit to jrha/configuration-modules-core that referenced this pull request Jul 28, 2023
@jrha
ncm-network: Add support for CAF::Service actions after changes
4401f48 
Largely transcribed from ncm-metaconfig.
Requires quattor#1335.
Resolves quattor#1071.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrha @stdweird @ned21