ncm-network: Add support for CAF::Service actions after changes #1336
+98
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdweird
reviewed
Oct 25, 2018
| @@ -1694,6 +1695,36 @@ sub down_rename_devices | |||
| return $action; | |||
| } | |||
|
|
|||
| # Prepare and take the action for all daemons as defined in hash-reference C<$daemons>. | |||
There was a problem hiding this comment.
i would like to see this moved (and perhaps generalised a bit) to CAF::Service. then we can use it in even more components. replace $self with $logger and export the function there
There was a problem hiding this comment.
Me too, are you volunteering? 😸
|
Try to use quattor/CAF#267 |
Largely transcribed from ncm-metaconfig. Requires quattor#1335. Resolves quattor#1071.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely transcribed from ncm-metaconfig.
Requires #1335.
Resolves #1071.