Fix regression in calling UIAElementInfo.descendants with depth and criteria like control_type arguments
#1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It was added for optimization of `UIAElementInfo.descendants` but is implemented in the base class - It was not suitable for exploring descendants as recursively retrieving the `children` of `children` filtered by the condition
argument names that can be passed to `build_condition`
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## atspi #1337 +/- ##
==========================================
- Coverage 94.15% 87.84% -6.31%
==========================================
Files 60 60
Lines 23036 23037 +1
==========================================
- Hits 21689 20238 -1451
- Misses 1347 2799 +1452 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1336