Add UIACondition and UIATreeWalker as wrappers for COM objects
#1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## atspi #1344 +/- ##
==========================================
- Coverage 94.15% 87.90% -6.25%
==========================================
Files 60 60
Lines 23036 23177 +141
==========================================
- Hits 21689 20374 -1315
- Misses 1347 2803 +1456 |
junkmd
force-pushed
the
add_uia_condtion_and_tree_walker
branch
from
8d0d48c
to
644ed4a
Compare
junkmd
changed the title
UIACondition and UIATreeWalker as wrappersUIACondition and UIATreeWalker as wrappers for COM objects
as wrapper of `IUIAutomationTreeWalker`
as wrapper of `IUIAutomationTreeWalker`
from using `IUIAutomation.ControlViewWalker` to using `UIATreeWalker`
junkmd
force-pushed
the
add_uia_condtion_and_tree_walker
branch
from
644ed4a
to
f849ce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(iter_)children/(iter_)descendantsmethods ofUIAElementInfohandleIUIAutomationConditonandIUIAutomationTreeWalkerdirectly.This leads to bloated codebases within these methods.
I think that providing appropriate wrappers for these can simplify the implementation of
UIAElementInfomethods, so I have added several classes for this purpose.I plan to replace the implementation of
(iter_)children/(iter_)descendantswith the codebase using the classes added in this PR once #1337 and #1334 are resolved.