Ensure that cache_enable propagates to the end of UIAElementInfo.iter_descendants
#1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and DRYing up the `UIAElementInfo` constructor calling
junkmd
changed the title
cache_enable propagates to the end of iter_descendantscache_enable propagates to the end of UIAElementInfo.iter_descendants
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## atspi #1334 +/- ##
==========================================
+ Coverage 94.15% 94.22% +0.07%
==========================================
Files 60 60
Lines 23036 23036
==========================================
+ Hits 21689 21706 +17
+ Misses 1347 1330 -17 |
In pywinauto#207, the `cache_enable` argument was added to the constructor, propagating to `children` and `descendants`. However, when `iter_children` and `iter_descendants` were introduced in pywinauto#475, `cache_enable` wasn't implemented to propagate. From reviewing past issues and PRs, it appears that not propagating `cache_enable` was unintentional and simply overlooked. pywinauto#1001 and pywinauto#1012 refactored the code without changing the current behavior, resulting in a complex conditional implementation.
with `is_element_satisfying_criteria` When `iter_descendants` is called recursively, it goes through `iter_descendants` first, so only elements filtered by `is_element_satisfying_criteria` are `yield`ed.
junkmd
force-pushed
the
update_uia_elem_info_iter_descendants
branch
from
4cf42b9
to
f736587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #207, the
cache_enableargument was added to the constructor and made to propagate down to the end ofdescendants. However, wheniter_descendantswas introduced in #475,cache_enablewasn't implemented to propagate down to the end.Upon reviewing past issues and PRs, it appears that not propagating
cache_enabledown to the end initer_descendantswas not intentional but simply overlooked.This PR addresses that inconsistency.