[dynamo] Fix test #125107
Closed
[dynamo] Fix test #125107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125107
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 24a77fe with merge base bad8d25 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 27, 2024
There was a problem hiding this comment.
What's wrong with this test?
Also, can we get #125062 in first? It adds an xfail to 3.12 and makes Mod.forward refer to self.fc instead of fc.
|
The test was returning input as well as fc. And we were passing both the input and the fc to the module call. This was exposed in a PR in this stack. I am fine rebasing after your PR goes in. |
jansel
approved these changes
Apr 28, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 28, 2024
Earlier globals of inlined functions from other files were not handled correctly. We were not tracking mutations on them. They were colliding with the same global name in the parent function etc. This PR overrides the LOAD/STORE_GLOBAL for inline tx and tracks mutation on them separately. Pull Request resolved: #125002 Approved by: https://github.com/jansel ghstack dependencies: #125097, #125107
carmocca
pushed a commit
to carmocca/pytorch
that referenced
this pull request
Apr 29, 2024
Pull Request resolved: pytorch#125107 Approved by: https://github.com/jansel ghstack dependencies: pytorch#125097
carmocca
pushed a commit
to carmocca/pytorch
that referenced
this pull request
Apr 29, 2024
Earlier globals of inlined functions from other files were not handled correctly. We were not tracking mutations on them. They were colliding with the same global name in the parent function etc. This PR overrides the LOAD/STORE_GLOBAL for inline tx and tracks mutation on them separately. Pull Request resolved: pytorch#125002 Approved by: https://github.com/jansel ghstack dependencies: pytorch#125097, pytorch#125107
andoorve
pushed a commit
to andoorve/pytorch
that referenced
this pull request
May 1, 2024
Pull Request resolved: pytorch#125107 Approved by: https://github.com/jansel ghstack dependencies: pytorch#125097
andoorve
pushed a commit
to andoorve/pytorch
that referenced
this pull request
May 1, 2024
Earlier globals of inlined functions from other files were not handled correctly. We were not tracking mutations on them. They were colliding with the same global name in the parent function etc. This PR overrides the LOAD/STORE_GLOBAL for inline tx and tracks mutation on them separately. Pull Request resolved: pytorch#125002 Approved by: https://github.com/jansel ghstack dependencies: pytorch#125097, pytorch#125107
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
May 3, 2024
Pull Request resolved: pytorch#125107 Approved by: https://github.com/jansel ghstack dependencies: pytorch#125097
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
May 3, 2024
Earlier globals of inlined functions from other files were not handled correctly. We were not tracking mutations on them. They were colliding with the same global name in the parent function etc. This PR overrides the LOAD/STORE_GLOBAL for inline tx and tracks mutation on them separately. Pull Request resolved: pytorch#125002 Approved by: https://github.com/jansel ghstack dependencies: pytorch#125097, pytorch#125107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @ezyang @msaroufim @bdhirsh @chauhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng