New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dynamo] Collect cell_and_freevars correctly #125097
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125097
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 51ccbc5 with merge base bad8d25 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc ezyang msaroufim bdhirsh chauhang voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire [ghstack-poisoned]
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Pull Request resolved: #125107 Approved by: https://github.com/jansel ghstack dependencies: #125097
Earlier globals of inlined functions from other files were not handled correctly. We were not tracking mutations on them. They were colliding with the same global name in the parent function etc. This PR overrides the LOAD/STORE_GLOBAL for inline tx and tracks mutation on them separately. Pull Request resolved: #125002 Approved by: https://github.com/jansel ghstack dependencies: #125097, #125107
Pull Request resolved: pytorch#125097 Approved by: https://github.com/Skylion007
Pull Request resolved: pytorch#125107 Approved by: https://github.com/jansel ghstack dependencies: pytorch#125097
Earlier globals of inlined functions from other files were not handled correctly. We were not tracking mutations on them. They were colliding with the same global name in the parent function etc. This PR overrides the LOAD/STORE_GLOBAL for inline tx and tracks mutation on them separately. Pull Request resolved: pytorch#125002 Approved by: https://github.com/jansel ghstack dependencies: pytorch#125097, pytorch#125107
Pull Request resolved: pytorch#125097 Approved by: https://github.com/Skylion007
Pull Request resolved: pytorch#125107 Approved by: https://github.com/jansel ghstack dependencies: pytorch#125097
Earlier globals of inlined functions from other files were not handled correctly. We were not tracking mutations on them. They were colliding with the same global name in the parent function etc. This PR overrides the LOAD/STORE_GLOBAL for inline tx and tracks mutation on them separately. Pull Request resolved: pytorch#125002 Approved by: https://github.com/jansel ghstack dependencies: pytorch#125097, pytorch#125107
Pull Request resolved: pytorch#125097 Approved by: https://github.com/Skylion007
Pull Request resolved: #125107 Approved by: https://github.com/jansel ghstack dependencies: #125097
Earlier globals of inlined functions from other files were not handled correctly. We were not tracking mutations on them. They were colliding with the same global name in the parent function etc. This PR overrides the LOAD/STORE_GLOBAL for inline tx and tracks mutation on them separately. Pull Request resolved: #125002 Approved by: https://github.com/jansel ghstack dependencies: #125097, #125107
Stack from ghstack (oldest at bottom):
cc @ezyang @msaroufim @bdhirsh @chauhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire