Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

Adding ACL support to std and tornado HTTP clients #205

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

tolmanam
Copy link

@tolmanam tolmanam commented Apr 2, 2018

I've been working on a tornado compatible python-nomad module (https://github.com/tolmanam/python-nomad-alt) based on the great work you've done with the python-consul project. I've tried to keep a lot of what you already have in place so that the two projects share most of the underlying connection logic, but I did add in ACL support to the tornado and standard HTTP clients.

I thought you might want to include the changes back into your project.

I've tested these changes over on my forked and reworked Nomad-alt project, but not against consul yet. I can try to work on that if you would like.

I also didn't have a need for twisted or aoi at this time so I haven't made any changes to those. Again, if you are interested in rolling these changes back into your project, I can take a longer look at these other clients as well.

Thanks

@tolmanam
Copy link
Author

tolmanam commented Apr 2, 2018

Please hold off on reviewing this build request. I've found a few issues that need to be addressed.

@tolmanam tolmanam closed this Apr 2, 2018
@tolmanam
Copy link
Author

tolmanam commented Apr 3, 2018

Unit tests are failing in places that I didn't touch. I've tested the code by hand and it seems to be working. Could use some help understanding the issue with the unit tests but otherwise, I think this branch is basically functional.

@tolmanam tolmanam reopened this Apr 3, 2018
@matusvalo
Copy link
Collaborator

@tolmanam I have fixed unittests. Could you please rebase from stable? Now it should be fine.

@tolmanam
Copy link
Author

Ah... this is not a good showing on my part.

I let a non-related commit slip into the acl_token_sopport branch (a change I had may to help me more easily manage version numbering that conflicts with your version schema.) so I've created a new branch without these commits called just 'acl_support.

I tried to rebase the new branch to master, but I think I messed up my GIT commands somewhere along the way because the GITHUB reports that branch "Can’t automatically merge".

Are you able to see the branch at https://github.com/tolmanam/python-consul/tree/acl_support? Does this look like a GIT problem that can be easily remedied or have I screwed things up too badly?

@cablehead cablehead force-pushed the master branch 2 times, most recently from 636f367 to a91daae Compare April 15, 2024 01:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants