Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

put token to header if present #203

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kapucko
Copy link

@kapucko kapucko commented Mar 21, 2018

Hi,

according to latest consul documentation for authentication: https://www.consul.io/api/index.html#authentication, consul client should insert token to the header when sending requests to agent.

This is my implementation, hopefully it'll help somebody.

Thank you for your great work.

Dominik

@kapucko
Copy link
Author

kapucko commented Mar 22, 2018

@cablehead I tried to fix tests but there is still this issue:
ValueError: Plugin already registered: pytest_twisted=<module 'pytest_twisted' from '/home/travis/build/cablehead/python-consul/.tox/py27/lib/python2.7/site-packages/pytest_twisted.py'>

I have seen it also it other PRs. Could you help me please?
Thank you.

@tolmanam
Copy link

tolmanam commented Apr 2, 2018

I took a very similar approach in my pull request (#205). I guess I should have checked here before submitting mine.
It's a bit encouraging that you also ran into issues with the unit tests.

@cablehead cablehead force-pushed the master branch 2 times, most recently from 636f367 to a91daae Compare April 15, 2024 01:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants