New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign Build System for PyNE with Scikit-Build #1500
Open
ahnaf-tahmid-chowdhury
wants to merge
279
commits into
pyne:develop
Choose a base branch
from
ahnaf-tahmid-chowdhury:scikit-build
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Redesign Build System for PyNE with Scikit-Build #1500
ahnaf-tahmid-chowdhury
wants to merge
279
commits into
pyne:develop
from
ahnaf-tahmid-chowdhury:scikit-build
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am unfamiliar with Windows and macOS workflows. I have copied the commands from a DAGMC workflow, but it seems that Windows is not recognizing the Makefile. Any suggestions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to redesign the PyNE build system using Scikit-Build, integrate MOAB and DAGMC support, and establish workflows for creating wheels and publishing them to PyPI. Additionally, it addresses the handling of the ENSDF Executables and the setup of nucdata during the build process.
Motivation and Context
The motivation for this PR is to enhance the build system, enabling better support for modern tools and libraries, and streamline the distribution process. It also prepares PyNE for future updates and ensures its compatibility with new versions of ENSDF.
Changes
This PR introduces the following changes:
Behavior
Current behavior
The existing build system might not be utilizing modern tools and libraries efficiently.
New behavior
The redesigned build system will leverage Scikit-Build, include MOAB and DAGMC support, and provide workflows for creating and publishing wheels to PyPI. It will also address the handling of ENSDF Executables and nucdata setup.
Other Information
Changelog file
I have updated the CHANGELOG file with this pull request.