Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Build System for PyNE with Scikit-Build #1500

Open
wants to merge 279 commits into
base: develop
Choose a base branch
from

Conversation

ahnaf-tahmid-chowdhury
Copy link
Member

Description

This PR aims to redesign the PyNE build system using Scikit-Build, integrate MOAB and DAGMC support, and establish workflows for creating wheels and publishing them to PyPI. Additionally, it addresses the handling of the ENSDF Executables and the setup of nucdata during the build process.

Motivation and Context

The motivation for this PR is to enhance the build system, enabling better support for modern tools and libraries, and streamline the distribution process. It also prepares PyNE for future updates and ensures its compatibility with new versions of ENSDF.

Changes

This PR introduces the following changes:

  • Redesign of the build system using Scikit-Build.
  • Integration of MOAB support.
  • Integration of DAGMC support.
  • Implementation of workflows for building wheels and publishing to PyPI.
  • Handling of the ENSDF Executables, considering the potential for future updates.
  • Setup of nucdata during the build process.

Behavior

Current behavior

The existing build system might not be utilizing modern tools and libraries efficiently.

New behavior

The redesigned build system will leverage Scikit-Build, include MOAB and DAGMC support, and provide workflows for creating and publishing wheels to PyPI. It will also address the handling of ENSDF Executables and nucdata setup.

Other Information

  • Please review and provide feedback on the proposed changes. Any additional suggestions or concerns are welcome.
  • If there are any specific issues or challenges related to this PR, please mention them here.

Changelog file

I have updated the CHANGELOG file with this pull request.

@ahnaf-tahmid-chowdhury
Copy link
Member Author

I am unfamiliar with Windows and macOS workflows. I have copied the commands from a DAGMC workflow, but it seems that Windows is not recognizing the Makefile. Any suggestions?

@ahnaf-tahmid-chowdhury ahnaf-tahmid-chowdhury marked this pull request as ready for review December 1, 2023 13:15
@ahnaf-tahmid-chowdhury ahnaf-tahmid-chowdhury linked an issue Jan 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant