Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve KLL Sketch perf for non-grouped queries #22619

Merged
merged 1 commit into from May 1, 2024

Commits on Apr 26, 2024

  1. Improve KLL Sketch perf for non-grouped queries

    The current method for calculating memory usage has a hidden cost.
    Within getEstimatedKllInMemorySize we call getSerializedSizeBytes.
    The code for the serialized bytes size actually serializes the entire
    internal state to a byte array first before returning the length. This
    is expensive and should be avoided.
    
    I am working on a PR to the upstream library to add a less-costly method
    but until released, I would like to fix this as non-grouped execution
    doesn't need the memory accounting for every sketch input.
    ZacBlanco committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9afd5b0 View commit details
    Browse the repository at this point in the history