Improve KLL Sketch perf for non-grouped queries #22619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Defers calculations of memory sizes for Kll sketches unless using a grouped query.
Motivation and Context
The current method for calculating memory usage has a hidden cost. Within
getEstimatedKllInMemorySize
we callgetSerializedSizeBytes
. The code for the serialized bytes size actually serializes the entire internal state to a byte array first before returning the length. This is expensive and should be avoided.I am working on a PR to the upstream library to add a less-costly method but until released, I would like to fix this as non-grouped execution doesn't need the memory accounting for every sketch input.
Impact
N/A
Test Plan
N/A
Contributor checklist
Release Notes