Patches for running in a flatpak #7359
Conversation
razzeee
force-pushed
the
use-config-home-flatpak
branch
from
10cd2a4
to
b1c711e
Compare
|
Unsure why the tests on macOS fail |
You can ignore that. Its a JS test case, which is failing randomly. |
|
@akshay-joshi would it be fine to cherry pick that into this branch? |
This is just a basic version of a metainfo file, it could be improved in various aspects, but having something basic already in tree would already be helpful.
I have cherry picked the commit. |
|
This should be good to go, unless there was another release in the mean time. Not sure, if you need to document/automate the addition of the release line in some way. |
|
@razzeee You've made it compatible when running from flatpak. But the automated build process need to include flatpak build and publish it flatpak to flathub just like docker hub. |
There's no way (for me) to publish it to flathub (and thus it doesn't make much sense to build the flatpak here) - you would need to reach out and ask for credentials. "Direct uploads" are a gated feature right now and I'm not sure, if @barthalion would allow your project into that test group. The other way would be the repo on the flathub github, to manage the manifest. But that would ideally need this to be merged. What I was asking about, was if there was automatic tooling generating the release notes/versions. Or if there are docs, that need to be extended to cover the process. |
|
Hi @razzeee, We are not planning to support the Flatpak packages yet, so it doesn't make sense to add the metainfo file to the repo. However, we can commit the path-related changes. Please remove the metainfo file from the PR so we can merge the remaining changes. |
|
So you're saying, I should revert the combination of the two PRs and split this up again into the two PRs like it was at the start? |
These are the needed patches we would need to be able to run pgadmin in a flatpak.
They stem of the work in https://github.com/flathub/flathub/pull/5105/files where we're doing this (much) worse with
sed.I think there might be a better solution for parts of this, but I'm not sure how to get there. Having this up-streamed at least would help us for the time being.