Add org.pgadmin.pgadmin4 #5105
Add org.pgadmin.pgadmin4 #5105
Conversation
| url: https://ftp.postgresql.org/pub/pgadmin/pgadmin4/apt/jammy/dists/pgadmin4/main/binary-amd64/pgadmin4-server_8.4_amd64.deb | ||
| dest-filename: pgadmin-server.deb |
There was a problem hiding this comment.
Why is this and below not being built from source?
There was a problem hiding this comment.
Can metainfo be submitted upstream?
There was a problem hiding this comment.
Created pgadmin-org/pgadmin4#7333 a week ago
There was a problem hiding this comment.
Upstream does not want metainfo right now pgadmin-org/pgadmin4#7359 (comment)
| - tar -xf data.tar.zst | ||
| - rm -rf usr/pgadmin4/venv | ||
| - cp -r usr/* /app/ | ||
| - sed -i "233 i DATA_DIR = os.environ['XDG_CONFIG_HOME']" /app/pgadmin4/web/config.py |
There was a problem hiding this comment.
isn't there a better way than sed?
There was a problem hiding this comment.
This would be much better I think pgadmin-org/pgadmin4#7359
I'm not sure if the other sed command could be removed, if we place the folders differently @faveoled might know.
There was a problem hiding this comment.
patches are always better. because patches can fail. while sed will just move on silently.
There was a problem hiding this comment.
should work without sed after PR approval
There was a problem hiding this comment.
I guess my question was more along the lines of, can we change the folder structure so that we don't need, this at all:
- sed -i "43 i pgadminFile = '/app/pgadmin4/web/pgAdmin4.py'" ${FLATPAK_DEST}/pgadmin4/bin/src/js/pgadmin.js
As the default is
let pgadminFile = '../web/pgAdmin4.py';
I'm also now wondering why we don't need to patch
let configFile = '../web/config.py';
|
Upstream does not want the metainfo file for now pgadmin-org/pgadmin4#7359 (comment) |
This is pgadmin4 the management utility for postgresql - I'm not involved with upstream at all.
There is pgadmin-org/pgadmin4#4378
Please confirm your submission meets all the criteria