Don't Use Maven Exec for 3rd Party License #6541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandrex247
force-pushed
the
3rd-party-build-improvement-Comm
branch
from
84f3a22
to
9181976
Compare
kalinchan
approved these changes
Jan 30, 2024
Pandrex247
force-pushed
the
3rd-party-build-improvement-Comm
branch
from
9181976
to
02a93af
Compare
Pandrex247
force-pushed
the
3rd-party-build-improvement-Comm
branch
from
df76889
to
f34db60
Compare
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Pandrex247
force-pushed
the
3rd-party-build-improvement-Comm
branch
from
f34db60
to
a06100c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches us from using maven exec to spin up a maven command inside our own maven command to more simply binding to a lifecycle phase.
Also updates us to the latest 2.4.0
Important Info
Blockers
None
Testing
New tests
None
Testing Performed
Cleared maven repo.
Built server.
Checked that no unstaged changes:
git statusChecked that a 3rd party license has been bundled in the Payara Server distribution under
payara6/glassfish/legalChanged Jackson version to 2.16.1 and rebuilt server.
Checked that a 3rd party license bundled in the Payara Server distribution under
payara6/glassfish/legalhas been updated appropriately.Testing Environment
Windows 11
Documentation
N/A
Notes for Reviewers
None