Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-8634 Add Jakarta Staging Repo #6641

Merged
merged 4 commits into from May 1, 2024

Conversation

Pandrex247
Copy link
Member

Description

Adds the Jakarta staging repo as a Maven repository (under a profile)
Also cherry-picks #6541 because otherwise the exec ignores the command line defined profile (since it spins up a new maven command).

Important Info

Blockers

None

Testing

New tests

None

Testing Performed

Cleaned maven repo, built server with jakarta.security.enterprise.version set to 4.0.0-M3

Testing Environment

WSL

Documentation

N/A

Notes for Reviewers

None

Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247
Copy link
Member Author

OK apparently I jumped the gun making this.
The issue Jenkins comes across from the original PR which I could never reproduce, I have now reproduced with this branch.

How me not using exec for the license job and instead binding it to a standard lifecycle stage breaks the packaging for cluster-admin, I have no idea.

Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pandrex247 Pandrex247 added the PR: DO NOT MERGE Don't merge PR until further notice label Apr 25, 2024
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
@Pandrex247 Pandrex247 removed the PR: DO NOT MERGE Don't merge PR until further notice label May 1, 2024
@Pandrex247 Pandrex247 changed the title Add Jakarta Staging Repo FISH-8634 Add Jakarta Staging Repo May 1, 2024
@Pandrex247 Pandrex247 merged commit 9fd2ff2 into payara:Payara7 May 1, 2024
1 check passed
@Pandrex247 Pandrex247 deleted the Add-Jakarta-Staging-Repo branch May 1, 2024 08:21
@Pandrex247 Pandrex247 restored the Add-Jakarta-Staging-Repo branch May 1, 2024 08:21
@Pandrex247 Pandrex247 deleted the Add-Jakarta-Staging-Repo branch May 1, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants