Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[milestone/12.3] Milestone 12.3 #1356

Merged
merged 15 commits into from
May 27, 2024
Merged

[milestone/12.3] Milestone 12.3 #1356

merged 15 commits into from
May 27, 2024

Conversation

felix-schwarz
Copy link
Contributor

@felix-schwarz felix-schwarz commented May 7, 2024

Description

Target PR for all changes in milestone 12.3. Already merged:

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Added an issue with details about all relevant changes in the iOS documentation repository.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@delete-merged-branch delete-merged-branch bot deleted the branch master May 8, 2024 13:44
@felix-schwarz felix-schwarz changed the base branch from milestone/12.2.1 to master May 13, 2024 08:23
@felix-schwarz
Copy link
Contributor Author

After merge, progress on 12.3 is tracked in:

felix-schwarz and others added 15 commits May 27, 2024 14:56
- INIFile+URLFile: simple extension for quickly parsing and composing .url files
- URLDisplayViewController: stub implementation to handle .url files
…ng shortcut URL

- CreateURLShortcutAction: new action to create a URL shortcut in a folder
- design and add "text-uri-list" icon
… open files from file lists, overriding viewers if needed

- OCItem+Interactions: add support for `.directOpen` actions
- INIFile+ShortcutResolution: implement support for shortcuts to other items on the same server
- ShortcutFileDisplayViewController: implement support for shortcuts to other items on the same server, including an item preview
- add new action OpenShortcutFileAction
	- hooks into the `.directOpen` location
	- uses INIFile+ShortcutResolution to open the contained link or jump to the targeted location
	- asks users before opening links
- rename files for better distinctibility:
	- URLDisplayViewController -> ShortcutFileDisplayViewController
	- CreateURLShortcutAction -> CreateShortcutFileAction
- OCItem+UniversalItemListCellContentProvider: fix warning
- CreateShortcutFileAction: break out creation functionality into its own view controller
- CreateShortcutFileViewController:
	- dedicated view controller for creating shortcuts
	- allows picking files and folders for shortcuts to point to and presents an embedded preview for them
	- improved error handling
- INIFile: fix formatting bug that could accidentally leak memory into the .url file
- ClientLocationPicker: add ability to allow picking files via new .allowFileSelection property
…targeting unavailable/detached drives and removes the respective policies

- adapt app code to SDK API changes
	- improved error reporting for when the target of a shortcut can't be accessed / found
	- simplified and generalized prompt for opening the URL a shortcut points to
…ShortcutResolution: add MDM option to allow all shortcuts, only URL shortcuts, only item shortcuts or no shortcuts
…root, the name for the shortcut was not derived correctly
- Localizable.strings: re-add strings auto-removed by git during rebase
- ios-sdk: use branch fix/warnings that fixes OpenSSL warnings
- replace associated keys using structs or strings with static malloc results as suggested by Apple Engineer Quinn (https://forums.swift.org/t/handling-the-new-forming-unsaferawpointer-warning/65523/7)
- remove unneeded/unused overrides
- reformat spacing in parts of the code and remove superfluous spaces to remove SwiftLint warnings
- replace calls to CLLocationManager.authorizationStatus() with CLLocationManager.authorizationStatus
- remove deprecated OpenSSL ERR_load_* calls, since OpenSSL loads these automatically (https://www.openssl.org/docs/man3.3/man7/migration_guide.html)
- LAContext+Extension: add cases for Optic ID
- remove unused variables and calls
- remove unused, non-existent "gear.png" image from asset catalog
@TheOneRing TheOneRing merged commit 8b0772e into master May 27, 2024
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the milestone/12.3 branch May 27, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants