[fix/a11y] Fix accessibility issues

[felix-schwarz]

Description

Fixes #1329, #1330, #1333, #1340.

Related Issue

#1329 : Approved
#1330 : Issues to review
#1333 : Approved
#1340 : Approved

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[jesmrec]

#1329

Personal space

• The "Menu" button has an alternative text, but this is in English and appears to be the name of a variable.
  in English and appears to be the name of a variable.
• The "Plus" button ("+") has an alternative text, but it is in English - "Add item".
  in English - "Add item". As this version of the app is a German version
  a German version, the alternative text should be in German.
• Note: The list of directories and files contains a "More" button in each
  list item contains a "More" button. To support screen reader users
  users, it would be advisable to display not only the word "More", but also the name of the
  name of the directory or file.

Menu, Shared with me, Spaces

• The "Menu" button does have an alternative text, but this is in
  English and appears to be the name of a variable.

Shared with others

• The "Menu" button does have an alternative text, but this is in English
  in English and appears to be the name of a variable.
• The button with the arrow pointing to the right does have an alternative text
  alternative text, but it is in English and not in German.

Image Viewer

• The "Menu" button has an alternative text, but this is in English and appears to be the name of a variable.
  in English and appears to be the name of a variable.
• The alternative text of the "Actions" button contains both the word
  "Actions" as well as the file name, which makes it difficult to understand.
  leads to poor comprehensibility. It is recommended to remove the file name from the alternative text.
  from the alternative text.

NOTE: Translations to german is not an app feature, i assume that existing translations are OK for German language

[jesmrec]

#1330

Personal Space and Shared with me

• Each directory or file in the list has "status" icons that show users whether the file has already been
  users whether the file has already been shared, for example. Unfortunately
  these icons are not displayed by screen readers, so this information is not accessible to
  not accessible to screen reader users. -> every of this images is spelt together with "Actions available" during dictation. But, those icons are only indicators about the file status and no action is available by clicking on them or any other gesture. is that right @felix-schwarz ?

Image Viewer

• When focusing on the image with the screen reader, the description of the image is not displayed.
  image, but information such as size and date entries. -> i don't understand what's going on here. What does "description of the image" mean? afaik, we don't describe images, not sure how to check this one

[jesmrec]

#1333

Menu

• The status of the user is only shown by colored dots. There is no other option is offered to recognize the status, for example through a text alternative.
  • Online (green)
  • Connecting (yellow)
  • Authentication error/Offline (red)

[jesmrec]

#1340

Shared with me

• The visual labels of the "Accept" and "Reject" buttons are not included in the accessible accessible name, as the accessible name is displayed in English. is output in English.

NOTE: Translations to german is not an app feature, i assume that existing translations are OK for German language

[felix-schwarz]

Personal Space and Shared with me

• Each directory or file in the list has "status" icons that show users whether the file has already been
  users whether the file has already been shared, for example. Unfortunately
  these icons are not displayed by screen readers, so this information is not accessible to
  not accessible to screen reader users. -> every of this images is spelt together with "Actions available" during dictation. But, those icons are only indicators about the file status and no action is available by clicking on them or any other gesture. is that right @felix-schwarz ?

@jesmrec As far as I can see, the actions are inherited from the parent views / accessibility elements and can't be removed by the children:

Triggering these actions triggers the respective actions of the parent views.

When I let Accessibility Inspector mimic VoiceOver by reading the description, it only read "Shared by link, image". What needs to be done to get VoiceOver to also say "Actions available"?

Image Viewer

• When focusing on the image with the screen reader, the description of the image is not displayed.
  image, but information such as size and date entries. -> i don't understand what's going on here. What does "description of the image" mean? afaik, we don't describe images, not sure how to check this one

The file viewer shows general file information while loading the file (or for files that don't exist locally and can't be downloaded for f.ex. lack of connection). Once the file is loaded, that information is covered by the viewed file.

Previously, that file information was still read out loud because it was still part of the view hierarchy. Now, after the fix, it is no longer read out.

[jesmrec]

When I let Accessibility Inspector mimic VoiceOver by reading the description, it only read "Shared by link, image". What needs to be done to get VoiceOver to also say "Actions available"?

Just clicking on the items, Voice Over spells:

• "Available offline image. Actions available"
• "Shared image. Actions available"
• "Shared by link image. Actions available"

Mi device is a iPhone XR iOS17.4.1

The file viewer shows general file information while loading the file (or for files that don't exist locally and can't be downloaded for f.ex. lack of connection). Once the file is loaded, that information is covered by the viewed file. Previously, that file information was still read out loud because it was still part of the view hierarchy. Now, after the fix, it is no longer read out.

Thanks for clarifying!