Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngtcp2: update to 1.4.0 #23744

Merged
merged 1 commit into from Mar 29, 2024
Merged

ngtcp2: update to 1.4.0 #23744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions libs/ngtcp2/Makefile
View file
Open in desktop
@@ -1,12 +1,12 @@
include $(TOPDIR)/rules.mk

PKG_NAME:=ngtcp2
PKG_VERSION:=1.1.0
PKG_RELEASE:=1
PKG_VERSION:=1.4.0
PKG_RELEASE:=r1

PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
PKG_SOURCE_URL:=https://codeload.github.com/ngtcp2/ngtcp2/tar.gz/v$(PKG_VERSION)?
PKG_HASH:=987d784643edea4f2859c405f7dfbc53871a9f7ae5fcddf5fb12ec5dfce1ef22
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
stangri marked this conversation as resolved.
Show resolved Hide resolved
PKG_SOURCE_URL:=https://github.com/ngtcp2/$(PKG_NAME)/releases/download/v$(PKG_VERSION)/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PKG_SOURCE_URL:=https://github.com/ngtcp2/$(PKG_NAME)/releases/download/v$(PKG_VERSION)/
PKG_SOURCE_URL:=https://github.com/ngtcp2/ngtcp2/releases/download/v$(PKG_VERSION)/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK: https://github.com/search?q=repo%3Aopenwrt%2Fpackages%20%24(PKG_NAME)%2Freleases&type=code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While looking at it, I am not sure what you would like to say. There are just a few packages looking at the URL, which you posted. Others are not related for PKG_SOURCE_URL, but nice attempt, I need to say! :) This conversation is not resolved and also, why you are merging it when I didnt have any chance to respond?

Reference:
#4119

I am sorry to ask, but what was your reason to change it? Make it harder to copy paste it to browser? I think so, because: https://github.com/ngtcp2/$(PKG_NAME)/ says 404. Your change makes it harder to read, to copy paste, well, for everything. There was no need to do it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So yes, avoid using $(PKG_NAME) for repo URL.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BKPepe @1715173329 do you gentlemen want to clean up all the other Makefiles containing $(PKG_NAME)/releases
in the PKG_SOURCE_URL?: https://github.com/search?q=repo%3Aopenwrt%2Fpackages%20%24(PKG_NAME)%2Freleases&type=code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were introduced for history reasons but let's not add new.

PKG_HASH:=b5d1433b9f5c06ce249e1e390e97dcfa49bf7ada5cb7c8bed8e6cd4feaf1ca4a

PKG_LICENSE:=MIT
PKG_LICENSE_FILES:=COPYING
Expand All @@ -22,7 +22,7 @@ define Package/libngtcp2
CATEGORY:=Libraries
TITLE:=Implementation of QUIC protocol
URL:=https://nghttp2.org/ngtcp2
DEPENDS:=+libnghttp3 +libopenssl
DEPENDS:=+libnghttp3
endef

define Package/libngtcp2/description
Expand Down