ngtcp2: update to 1.4.0 #23744
ngtcp2: update to 1.4.0 #23744
Conversation
* update PKG_RELEASE to be apk-compatible * update PKG_SOURCE/PKG_SOURCE_URL so that it builds * drop dependency on libopenssl as other SSL libs start to support HTTP/3 Signed-off-by: Stan Grishin <stangri@melmac.ca>
| PKG_SOURCE_URL:=https://codeload.github.com/ngtcp2/ngtcp2/tar.gz/v$(PKG_VERSION)? | ||
| PKG_HASH:=987d784643edea4f2859c405f7dfbc53871a9f7ae5fcddf5fb12ec5dfce1ef22 | ||
| PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz | ||
| PKG_SOURCE_URL:=https://github.com/ngtcp2/$(PKG_NAME)/releases/download/v$(PKG_VERSION)/ |
There was a problem hiding this comment.
| PKG_SOURCE_URL:=https://github.com/ngtcp2/$(PKG_NAME)/releases/download/v$(PKG_VERSION)/ | |
| PKG_SOURCE_URL:=https://github.com/ngtcp2/ngtcp2/releases/download/v$(PKG_VERSION)/ |
There was a problem hiding this comment.
There was a problem hiding this comment.
While looking at it, I am not sure what you would like to say. There are just a few packages looking at the URL, which you posted. Others are not related for PKG_SOURCE_URL, but nice attempt, I need to say! :) This conversation is not resolved and also, why you are merging it when I didnt have any chance to respond?
Reference:
#4119
I am sorry to ask, but what was your reason to change it? Make it harder to copy paste it to browser? I think so, because: https://github.com/ngtcp2/$(PKG_NAME)/ says 404. Your change makes it harder to read, to copy paste, well, for everything. There was no need to do it.
There was a problem hiding this comment.
So yes, avoid using $(PKG_NAME) for repo URL.
There was a problem hiding this comment.
@BKPepe @1715173329 do you gentlemen want to clean up all the other Makefiles containing $(PKG_NAME)/releases
in the PKG_SOURCE_URL?: https://github.com/search?q=repo%3Aopenwrt%2Fpackages%20%24(PKG_NAME)%2Freleases&type=code
There was a problem hiding this comment.
They were introduced for history reasons but let's not add new.
Maintainer: me
Compile tested: x86_64, Sophos XG-135r3, OpenWrt 23.05.2
Description: