Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WINDOWS.md #24242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update WINDOWS.md #24242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions doc/designs/ddd/WINDOWS.md
View file
Open in desktop
Expand Up @@ -2,11 +2,11 @@ Windows-related issues
======================

Supporting Windows introduces some complications due to some "fun" peculiarities
of Windows's socket API.
of Windows socket API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The possessive form of "Windows" has been updated from "Windows's" to "Windows'".

One too many---the apostrophe disappeared :D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO OK without the apostrophe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also find Windows socket API is already very understandable. Just like we usually use the term Linux/Unix socket programming instead of Linux's socket...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Windows' - apostrophe at the end. It's hard to see in @bbbrumley's comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should either be ... peculiarities of the Windows socket API or ... peculiarities of Windows' socket API. I think the former would be better

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @ha1215 peculiarities of Windows socket API isn't right, and should preferably be changed to peculiarities of the Windows socket API (avoids all the apostrophe-after-s concerns)


In general, Windows does not provide a poll(2) call. WSAPoll(2) was introduced
in Vista and supposed to bring this functionality, but it had a bug in it which
Microsoft refused to fix, making it rather pointless. However Microsoft has now
In general, Windows does not provide a poll(2) system call. WSAPoll(2) was introduced
in Vista and was supposed to bring this functionality, but it had a bug in it which
Microsoft refused to fix, making it rather pointless. However, Microsoft has now
finally fixed this bug in a build of Windows 10. So WSAPoll(2) is a viable
method, but only on fairly new versions of Windows.

Expand All @@ -23,7 +23,7 @@ Windows does not provide anything like epoll or kqueue. For high performance
network I/O, you are expected to use a Windows API called I/O Completion Ports
(IOCP).

Supporting these is a pain for applications designed around polling. The reason
Supporting these can be a pain for applications designed around polling. The reason
is that IOCPs are a higher-level interface; it is easy to build an IOCP-like
interface on top of polling, but it is not really possible to build a
polling-like interface on top of IOCPs.
Expand Down