Update WINDOWS.md #24242
Update WINDOWS.md #24242
Conversation
The possessive form of "Windows" has been updated from "Windows's" to "Windows'". The function call "a poll(2) call" has been specified as "a poll(2) system call" for clarity. The phrase "and supposed" has been corrected to "and was supposed" to improve sentence structure. The phrase "However Microsoft has" now includes a comma, revised to "However, Microsoft has," to enhance readability. The statement "Supporting these is a pain" has been adjusted to "Supporting these can be a pain" to better convey potential variability in user experience.
openssl-machine
added
the
hold: cla required
| @@ -2,11 +2,11 @@ Windows-related issues | |||
| ====================== | |||
|
|
|||
| Supporting Windows introduces some complications due to some "fun" peculiarities | |||
| of Windows's socket API. | |||
| of Windows socket API. | |||
There was a problem hiding this comment.
The possessive form of "Windows" has been updated from "Windows's" to "Windows'".
One too many---the apostrophe disappeared :D
There was a problem hiding this comment.
I also find Windows socket API is already very understandable. Just like we usually use the term Linux/Unix socket programming instead of Linux's socket...
There was a problem hiding this comment.
Should be Windows' - apostrophe at the end. It's hard to see in @bbbrumley's comment
There was a problem hiding this comment.
It should either be ... peculiarities of the Windows socket API or ... peculiarities of Windows' socket API. I think the former would be better
|
Thanks! Let's see what the maintainers say. For This looks fine to me, but the maintainers are still gonna want the |
t8m
added
branch: master
mattcaswell
added
the
approval: review pending
The possessive form of "Windows" has been updated from "Windows's" to "Windows'".
The function call "a poll(2) call" has been specified as "a poll(2) system call" for clarity.
The phrase "and supposed" has been corrected to "and was supposed" to improve sentence structure.
The phrase "However Microsoft has" now includes a comma, revised to "However, Microsoft has," to enhance readability.
The statement "Supporting these is a pain" has been adjusted to "Supporting these can be a pain" to better convey potential variability in user experience.
CLA: trivial
This is my PR requests for the Software Engineering Assignment with @bbbrumley.