Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix):Prevent multiple provider room modal shown on service queue Change #962

Closed
wants to merge 1 commit into from
Closed

(fix):Prevent multiple provider room modal shown on service queue Change #962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/esm-service-queues-app/src/active-visits/active-visits-table.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,13 @@ function ActiveVisitsTable() {
launchAddProviderRoomModal,
]);

useEffect(() => {
// Clean up the modal state when navigating away or resetting provider room
return () => {
setProviderRoomModalShown(false);
};
}, [setProviderRoomModalShown]);
Comment on lines +268 to +273
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like one of those cases where you might not need an effect. When should the modal be shown? There's other approaches suggested in the article that could be more appropriate in this instance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the code. @makombe when should the modal be shown? This useEffect callback will only be run when navigating away from the page that has the active-visits-table. This will not prevent multiple modals from showing, right?


if (isLoading) {
return <DataTableSkeleton role="progressbar" />;
}
Expand Down