(fix):Prevent multiple provider room modal shown on service queue Change #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
reviewed
Feb 5, 2024
Comment on lines
+268
to
+273
| useEffect(() => { | ||
| // Clean up the modal state when navigating away or resetting provider room | ||
| return () => { | ||
| setProviderRoomModalShown(false); | ||
| }; | ||
| }, [setProviderRoomModalShown]); |
There was a problem hiding this comment.
This feels like one of those cases where you might not need an effect. When should the modal be shown? There's other approaches suggested in the article that could be more appropriate in this instance.
There was a problem hiding this comment.
I'm not too familiar with the code. @makombe when should the modal be shown? This useEffect callback will only be run when navigating away from the page that has the active-visits-table. This will not prevent multiple modals from showing, right?
sam-sny
approved these changes
Mar 21, 2024
|
There aren't any screenshots of the changes |
|
@chibongho you alluded to this on today's squad call. Any thoughts on the approach? |
|
I think we can close this with this commit. Please re-open if that's not the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
Related Issue
Other