Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) O3-2852: Fix the viewport size of the Start Visit form on tablet #1765

Merged
merged 4 commits into from
May 8, 2024
Merged

(fix) O3-2852: Fix the viewport size of the Start Visit form on tablet #1765

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dc1216
Overlapping issue fixed in visit-form
Madhu-mac Mar 29, 2024
d5489de
Merge branch 'main' into Fix/Visit-form-tablet-view
mozzy11 Apr 1, 2024
3675315
Merge branch 'main' into Fix/Visit-form-tablet-view
denniskigen May 8, 2024
29d73ef
Make viewport height responsive - different values for desktop and ta…
denniskigen May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/esm-patient-chart-app/src/visit/visit-form/visit-form.scss
View file
Open in desktop
Expand Up @@ -13,7 +13,6 @@

.heading {
@include type.type-style("heading-03");

margin: spacing.$spacing-05;
}

Expand Down Expand Up @@ -46,7 +45,7 @@
display: flex;
flex-direction: column;
justify-content: space-between;
height: calc(100vh - 6rem);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Madhu-mac changing the height to 100vh breaks the UI on the desktop viewport. The correct values are:

  • var(--desktop-workspace-window-height) for desktop
  • var(--tablet-workspace-window-height) for tablet

As defined here

This is what the corresponding UI looks like following those changes:

Desktop

CleanShot 2024-05-09 at 1  54 56@2x

Tablet

CleanShot 2024-05-09 at 1  54 42@2x

height: var(--desktop-workspace-window-height);
}

.button {
Expand Down Expand Up @@ -104,4 +103,8 @@
}
}
}

.form {
height: var(--tablet-workspace-window-height);
}
}