(fix) O3-2852: Fix the viewport size of the Start Visit form on tablet #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@denniskigen I Fixed this error. Can you review it.. |
|
@Madhu-mac Kindly Add the ticket link associated with the issue. |
denniskigen
reviewed
May 8, 2024
| @@ -46,7 +45,7 @@ | |||
| display: flex; | |||
| flex-direction: column; | |||
| justify-content: space-between; | |||
| height: calc(100vh - 6rem); | |||
There was a problem hiding this comment.
@Madhu-mac changing the height to 100vh breaks the UI on the desktop viewport. The correct values are:
var(--desktop-workspace-window-height)for desktopvar(--tablet-workspace-window-height)for tablet
As defined here
This is what the corresponding UI looks like following those changes:
Desktop
Tablet
denniskigen
changed the title
denniskigen
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Fixes the Start Visit form UI on the tablet viewport so that the form covers the entire vertical height of the viewport.
Screenshots
Before
After
Related issue
https://openmrs.atlassian.net/issues/O3-2852