Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the transaction pool #255

Closed
wants to merge 28 commits into from
Closed

Implement the transaction pool #255

wants to merge 28 commits into from

Commits on May 9, 2024

  1. Start implementation of the transaction pool 

    Implement it outside of the state machine for now.
We will integrate it later
    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7d908d8 View commit details
    Browse the repository at this point in the history

  2. Implement new caching logic in to_all_verifiable 

    See MinaProtocol/mina#14356
    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d5dcba0 View commit details
    Browse the repository at this point in the history

  3. Verify commands in the tx pool

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b1457cc View commit details
    Browse the repository at this point in the history

  4. Compute weight of commands

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    fa1aedb View commit details
    Browse the repository at this point in the history

  5. wip

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7f8d318 View commit details
    Browse the repository at this point in the history

  6. Implement time-related types/methods for tx pool

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    ed4a48f View commit details
    Browse the repository at this point in the history

  7. Implement IndexedPool::add_from_backtrack

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    28ad681 View commit details
    Browse the repository at this point in the history

  8. Implement part of IndexedPool::add_from_gossip_exn

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    471dfa6 View commit details
    Browse the repository at this point in the history

  9. Implement rest of add_from_gossip_exn 

    + Apply changes only when no errors occured
    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    9e057db View commit details
    Browse the repository at this point in the history

  10. Implement IndexedPool::revalidate

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    2da771c View commit details
    Browse the repository at this point in the history

  11. Make group_by_zkapp_command_rev generic, to use it in tx pool

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    2569c35 View commit details
    Browse the repository at this point in the history

  12. Implement ZkappCommand::valid_size

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    304f50b View commit details
    Browse the repository at this point in the history

  13. Fix after rebase

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    90369d3 View commit details
    Browse the repository at this point in the history

  14. Fix new warning "reduntant import"

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    8c8098e View commit details
    Browse the repository at this point in the history

  15. Add type AccountIdOrderable to make AccountId comparable 

    `AccountId` could already be compared (using `Ord`/`PartialOrd`) but we had
to re-compute the `BigInteger256` values every time
`PartialOrd::partial_cmp` was called.
This commit only make the comparaison (`Ord`/`PartialOrd`) faster.

Remove `Ord` & `PartialOrd` implementation for `AccountId`.
    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d2bc3aa View commit details
    Browse the repository at this point in the history

  16. Implement TransactionPool::get_rebroadcastable

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d9d3725 View commit details
    Browse the repository at this point in the history

  17. Use shared pointer for BlakeHash

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    ac4ab8e View commit details
    Browse the repository at this point in the history

  18. Integrate the pool in the state machine

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    196ce0f View commit details
    Browse the repository at this point in the history

  19. Fix after rebase

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c7ac527 View commit details
    Browse the repository at this point in the history

  20. Split TransactionPoolAction::BestTipChanged in 2 actions 

    The first fetches accounts from the ledger service
    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    fb236d6 View commit details
    Browse the repository at this point in the history

  21. Split other actions in 2 actions 

    We need to fetch accounts first
+ Remove `best_tip_ledger` in `TransactionPool`
    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    b8b6cbd View commit details
    Browse the repository at this point in the history

  22. Implement TransactionPool::transactions

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    44f2979 View commit details
    Browse the repository at this point in the history

  23. Add snark/user_command_verify Service 

    To check signatures and verify proofs contained in zkapps
    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    dd0dd02 View commit details
    Browse the repository at this point in the history

  24. Fix usage of SnarkUserCommandVerifyService

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    8027cd0 View commit details
    Browse the repository at this point in the history

  25. Fix after rebase

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c0bfa27 View commit details
    Browse the repository at this point in the history

  26. Serialize verifiable::UserCommand

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    4bca9b5 View commit details
    Browse the repository at this point in the history

  27. Fix after rebase

    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    df6cb14 View commit details
    Browse the repository at this point in the history

  28. Remove TransactionPoolLedgerService 

    Use `LedgerManager` directly
    @sebastiencs
    sebastiencs committed May 9, 2024
    Configuration menu
    Copy the full SHA
    8e88dcf View commit details
    Browse the repository at this point in the history