Implement the transaction pool #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiencs
changed the title
sebastiencs
force-pushed
the
tx-pool
branch
9 times, most recently
from
c9318ef
to
31353f2
Compare
sebastiencs
force-pushed
the
tx-pool
branch
10 times, most recently
from
3b74071
to
bf090c4
Compare
sebastiencs
force-pushed
the
tx-pool
branch
6 times, most recently
from
0118899
to
ec33389
Compare
sebastiencs
force-pushed
the
tx-pool
branch
2 times, most recently
from
4a7f153
to
168b71a
Compare
Implement it outside of the state machine for now. We will integrate it later
+ Apply changes only when no errors occured
`AccountId` could already be compared (using `Ord`/`PartialOrd`) but we had to re-compute the `BigInteger256` values every time `PartialOrd::partial_cmp` was called. This commit only make the comparaison (`Ord`/`PartialOrd`) faster. Remove `Ord` & `PartialOrd` implementation for `AccountId`.
The first fetches accounts from the ledger service
We need to fetch accounts first + Remove `best_tip_ledger` in `TransactionPool`
To check signatures and verify proofs contained in zkapps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the pool outside of the state machine for now