Allow partial expression evaluation on the CPU #15415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahow
force-pushed
the
partial-expression-cpu-evaluation
branch
from
c768967
to
895e1b9
Compare
|
📦 Preview the website for this branch here: https://deploy-preview-15415--ol-site.netlify.app/. |
jahow
force-pushed
the
partial-expression-cpu-evaluation
branch
5 times, most recently
from
9d86980
to
e1e015b
Compare
Evaluation contexts are now initialized with every properties set to UNKNOWN_VALUE. If an expression needs an input which is unknown, it will return UNKNOWN_VALUE.
Also added some tests for string assertion
jahow
force-pushed
the
partial-expression-cpu-evaluation
branch
from
e1e015b
to
5bf1277
Compare
This makes sure that icons are loaded before rendering
jahow
force-pushed
the
partial-expression-cpu-evaluation
branch
from
5bf1277
to
7f1719b
Compare
|
This is ready for review, thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for evaluation expressions on the CPU with an incomplete context (e.g. no feature, no resolution, etc.). An
UNKNOWN_VALUEconstant is introduced; it will be returned whenever an expression evaluates to something that is not defined, for instance trying to read a property if no feature properties have been provided in the context.This will be instrumental in preprocessing some parts of a style object for WebGL rendering (e.g. filters, string operations).
Rebased on #15414
Part of #15413
Note: this PR also improves the webgl fill/line pattern tests which were quite flakey