WebGL / Filter geometries before processing them for rendering #15416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-15416--ol-site.netlify.app/. |
tschaub
reviewed
Dec 9, 2023
tschaub
reviewed
Dec 9, 2023
tschaub
reviewed
Dec 9, 2023
5 tasks
Evaluation contexts are now initialized with every properties set to UNKNOWN_VALUE. If an expression needs an input which is unknown, it will return UNKNOWN_VALUE.
Also added some tests for string assertion
This makes sure that icons are loaded before rendering
This will be used to filter out features that will eventually be rendered
jahow
force-pushed
the
webgl-filter-geometry-earlier
branch
from
3bef70a
to
6cc7405
Compare
jahow
force-pushed
the
webgl-filter-geometry-earlier
branch
from
6cc7405
to
8166059
Compare
jahow
force-pushed
the
webgl-filter-geometry-earlier
branch
from
8166059
to
ce9daca
Compare
|
I added some missing tests, still very much open to suggestions and ideas on this! thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
filter()method on theMixedGeometryBatchclass. Before generating WebGL buffers from a geometry batch, theVectorStyleRendererwill apply the style filter and exclude from the batch any geometry that does not match this filter. The style filter expression is evaluated on the CPU.Some filters might not be evaluated at buffer generation time (e.g. a filter depending on
timeorresolutionwhich are dynamic parameters). This entails that the filter is also still applied on the GPU (fragment shader) to make sure that we filter our all relevant features at any given frame.This change typically makes vector tiles processing a little bit longer, but is essential when rendering styles composed of dozens of different rules where it provides a huge performance boost.
Rebased on #15415
Part of #15413