Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Angular 13.3.0 #769

Merged
merged 1 commit into from Mar 31, 2022
Merged

Update to Angular 13.3.0 #769

merged 1 commit into from Mar 31, 2022

Conversation

cschweikert
Copy link
Member

  • update Angular from 8.0.3 to 13.3.0
  • update nginx from 1.20.1 to 1.21.6
  • completly remove linting support
  • reduce amount of customization, especially remove the hardcoded version of package.json

Fixes #765

Tasks:

  • Updated documentation in docs/modules/... directory
  • Ran tests in <quickstarter>/testdata directory

Please note

  1. The support for TSLint will be removed from this quickstarter. Also Angular is not shipping a linter by default anymore. Please consider adding ESLint support or a formatter like Prettier. For adding ESLint simply type ng add @angular-eslint/schematics. For setting up Prettier please see https://prettier.io/docs/en/install.html.

  2. Angular 13.3.0 still works with version 12 of the nodeJS-based build agent. An update of this version is tackled Nodejs 12 EOL in April #763

  3. The unit testing capabilities are currently broken (see for exmple Quickstarter tests: Verifying Jenkins run attachments fails ods-core#1124 and Provisioning of projects doesn't setup Jenkins with Aqua credentials  ods-core#1125). I filled the gaps as good as I could with manual tests.

  4. There will be a follow-up PR for the 4.x branch.

bljubisic
bljubisic previously approved these changes Mar 28, 2022
@cschweikert
Copy link
Member Author

sry for the back and forth. Ready for review now 😅

fe-angular/init.sh Outdated Show resolved Hide resolved
netzartist
netzartist previously approved these changes Mar 28, 2022
bljubisic
bljubisic previously approved these changes Mar 28, 2022
@cschweikert cschweikert merged commit 196c8e4 into master Mar 31, 2022
This was referenced Mar 31, 2022
@cschweikert cschweikert deleted the update-angular-13 branch April 8, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fe-angular to 13.3+
3 participants