Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jenkins-agent-nodejs to nodeJS 16 #764

Merged
merged 1 commit into from Apr 1, 2022

Conversation

cschweikert
Copy link
Member

@cschweikert cschweikert commented Mar 18, 2022

  • add jenkins-agent for nodeJS 16
  • update chrome to 99.0.4844.74 (latest)
  • update yarn to 1.22.18 (latest)
  • update documentation

Fixes #763

Tasks:

  • Updated documentation in docs/modules/... directory
  • Ran tests in <quickstarter>/testdata directory

Please note

  1. as discussed in Nodejs 12 EOL in April #763, we wanted to keep the agent for nodejs 12 in parallel for master and 4.x branch
  2. The unit testing capabilities are currently broken (see for exmple Quickstarter tests: Verifying Jenkins run attachments fails ods-core#1124 and Provisioning of projects doesn't setup Jenkins with Aqua credentials  ods-core#1125). I filled the gaps as good as I could with manual tests.
  3. I can already tell that the upcoming version of fe-angular (see PR Update to Angular 13.3.0 #769) works fine with the new nodeJS 16 agent.

@cschweikert
Copy link
Member Author

Hi, I made a few changes on this PR. nodejs12 stays in and lies next to nodejs16 now. I'd also skip the migration of all quickstarters to nodejs16 for now. Code changes that relates to this migration I moved to a new branch: a47a77d

@cschweikert cschweikert changed the title [WIP] Update jenkins-agent-nodejs to nodeJS 16 Update jenkins-agent-nodejs to nodeJS 16 Mar 29, 2022
@cschweikert
Copy link
Member Author

Hi everybody, this PR is finally ready for review. I also updated some notes in the description on top.

netzartist
netzartist previously approved these changes Mar 29, 2022
@cschweikert
Copy link
Member Author

This PR is ready for review. Please also ignore the failing checks above. They currently are happening on all PRs and have nothing to do with the actual changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nodejs 12 EOL in April
2 participants