Emergency trigger to use transient local qos #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
arjo129
reviewed
Apr 16, 2024
There was a problem hiding this comment.
A quick grep shows that the LiftSupervisor node also publishes to this topic with default QoS. I'm not sure if we're using that but might be worth updating.
|
We don't actually publish on the emergency topic from the lift supervisor. A long time ago the intention was to do so, but it was later decided that the lift states are not necessarily a good source of truth for this, so now it's up to system integrators to decide when to publish emergency notices. If anything we should delete that publisher from the lift supervisor. |
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
arjo129
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the emergency topic subscriber transient local.