-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify the 'downloads' directory #327
Open
golirev
wants to merge
11
commits into
oneclick:master
Choose a base branch
from
golirev:gl-multi-toolchain
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c4b802c
Specify the 'downloads' directory
golirev 85639d9
Modify the indent
golirev 37d06bc
Upgrade Ruby 2.2 and 2.3 to 2.2.6 and 2.3.3 respectively
vais 4b6938e
Change History to reflect unreleased state
Azolo 12aae4d
Merge branch 'vais-master'
Azolo c8ff1af
Update Dependencies
Azolo 925af03
Retry timeouts with SourceForge
Azolo 5e4b7a3
Prep for release
Azolo e871184
Specify the 'downloads' directory
golirev 8f5f18f
Modify the indent
golirev d16b9c3
Merge branch 'gl-multi-toolchain' of https://github.com/golirev/rubyi…
golirev File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,19 +13,33 @@ dependencies.each do |dependency_key, dependency| | |
|
||
if compiler.host =~ /x86_64/ | ||
files = dependency.x64_files | ||
files_url = "#{dependency.url}/x64" | ||
if compiler.knap_path | ||
files_url = "#{dependency.url}/#{compiler.knap_path}/x64" | ||
else | ||
files_url = "#{dependency.url}/x64" | ||
end | ||
else | ||
files = dependency.files | ||
files_url = "#{dependency.url}/x86" | ||
if compiler.knap_path | ||
files_url = "#{dependency.url}/#{compiler.knap_path}/x86" | ||
else | ||
files_url = "#{dependency.url}/x86" | ||
end | ||
end | ||
|
||
download_path = RubyInstaller::DOWNLOADS | ||
if compiler.knap_path | ||
download_path = "#{download_path}/#{compiler.knap_path}" | ||
end | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you clean up the tabs in this file? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I modified the indent. |
||
files.each do |f| | ||
file_source = "#{files_url}/#{f}" | ||
file_target = "downloads/#{f}" | ||
file_target = "#{download_path}/#{f}" | ||
download file_target => file_source | ||
|
||
# depend on downloads directory | ||
file file_target => "downloads" | ||
file file_target => "#{download_path}" | ||
directory "#{download_path}" | ||
|
||
# download task need these files as pre-requisites | ||
dt.enhance [file_target] | ||
|
@@ -35,7 +49,7 @@ dependencies.each do |dependency_key, dependency| | |
# Prepare the :sandbox, it requires the :download task | ||
et = checkpoint(dependency_key, :extract) do | ||
dt.prerequisites.each { |f| | ||
extract(File.join(RubyInstaller::ROOT, f), dependency.target) | ||
extract(f, dependency.target) | ||
} | ||
end | ||
task :extract => [:extract_utils, :download, dependency.target, et] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad that someone is doing this kind of stuff. =)