Specify the 'downloads' directory #327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| download_path = RubyInstaller::DOWNLOADS | ||
| if compiler.knap_path | ||
| download_path = "#{download_path}/#{compiler.knap_path}" | ||
| end | ||
|
|
There was a problem hiding this comment.
Could you clean up the tabs in this file?
There was a problem hiding this comment.
I modified the indent.
Thank you.
|
It looks promising! |
|
I'm in the middle of getting some other stuff together, so give me a couple days and I'll look at it more closely. =) |
And deal multi-toolchain dependent files properly
golirev
force-pushed
the
gl-multi-toolchain
branch
from
6bef2a1
to
85639d9
Compare
- OpenSSL, libffi, LibYAML, tcl, tk
* SourceForge has become unreliable lately
- 2.2.6 `make test-all`: https://gist.github.com/Azolo/b9a2a55ff2e94265de882ee7aec9c663 - 2.3.3 `make test-all`: https://gist.github.com/Azolo/6f661dfceddd1ef8580bfde0c79eccb1
And deal multi-toolchain dependent files properly
…nstaller into gl-multi-toolchain
|
may need updating the software versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a way to specify the folder to place downloaded files.
You can share a "downloads" folder with multiple windows installer build instances
without copying from one instance to another.
rake DOWNLOADS="c:\downloads" # specify the folder to place downloaded files, absolute/relative
In addition above, I added the ability to handle dependency files
more properly in multi-toolchain.
Download a set of dependency files from distinguished URL path
and store them under the "downloads" sub-directory separately.
config/compilers/mingw64.rb is just a sample.
You'll fail in downloading the dependency files, since there aren't such files.
:knap_path value is used for separation.