Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Creates pr diff script to help analyze the impact of generated SDK PRs #53

Merged
merged 2 commits into from Apr 1, 2024

Conversation

nickfloyd
Copy link
Collaborator

No description provided.

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be worth adding a brief description and usage example in our README.

@kfcampbell
Copy link
Member

Note that when run against octokit/go-sdk#57, this script prints a blank commit message:

Commit message: FEAT:
Added lines: 7
Removed lines: 5

The script is failing to capture the addition of "406": i59ea7d99994c6a4bb9ef742ed717844297d055c7fd3742131406eea67a6404b6.CreateBasicErrorFromDiscriminatorValue, for some reason, which is interesting.

@kfcampbell
Copy link
Member

When attempting to fetch octokit/dotnet-sdk#55, it simply prints Failed to fetch PR diff. and returns, perhaps because it's not equipped to handle changes of the scale of the PR (2277 files changed at the time of writing).

@nickfloyd
Copy link
Collaborator Author

Note that when run against octokit/go-sdk#57, this script prints a blank commit message:

Commit message: FEAT:
Added lines: 7
Removed lines: 5

The script is failing to capture the addition of "406": i59ea7d99994c6a4bb9ef742ed717844297d055c7fd3742131406eea67a6404b6.CreateBasicErrorFromDiscriminatorValue, for some reason, which is interesting.

Interesting... I'll need to drop an issue in the repo to have a look at later. No idea why these two things would be happening.

@nickfloyd nickfloyd merged commit ba64dd8 into main Apr 1, 2024
5 checks passed
@nickfloyd nickfloyd deleted the adds-diff-script branch April 1, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants