Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #154 - Style error messages #574

Merged

Conversation

hilarysk
Copy link
Contributor

@hilarysk hilarysk commented May 8, 2024

What does this PR do?

  1. Styles in-page error messages
  2. Standardizes success flash messages in controllers
  3. Restyles radio buttons in submission new / edit form
Why was this work done? Is there a related Issue?

Issue #154

Where should a reviewer start?

Probably with the new error display partial

Are there any manual testing steps?

Attempt to edit or create anything.

Screenshots

Screen Shot 2024-05-08 at 3 26 48 PM Screen Shot 2024-05-08 at 3 25 39 PM Screen Shot 2024-05-08 at 3 07 08 PM

Deployment instructions

N/A

Database changes

N/A

New ENV variables

N/A

@hilarysk hilarysk force-pushed the hilarysk/issue-154-style-error-messages branch from 5ddcdfe to faa5656 Compare May 8, 2024 19:27
@nodunayo nodunayo merged commit 9e0e9a8 into nodunayo:master May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants