SubmissionsController: provide helpful redirects when invalid URLs are accessed #575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the
SubmissionsController
to add anindex
action and update thenew
action.index
action, we redirect to theproposals #index
route and display anotice
flash message.new
action, if there is noproposal
provided, we redirect to theproposals #index
route and display anotice
flash message.Why was this work done? Is there a related Issue?
This work was done in response to Issue Number 48, which notes that if someone happens to alter the URL (likely with knowledge of rails routes) to try to view the submissions index/new pages, an unhelpful error page is shown. The flash message should help contextualize the role of a submission, articulating why these pages do not exist (or need to exist).
Are there any manual testing steps?
http://localhost:3000/submissions/new
http://localhost:3000/submissions
Caveat about styling
This related CR by Hilary styles the flash messages, so they will look much better than shown below!!
Screenshots
http://localhost:3000/submissions/new
http://localhost:3000/submissions