Replace cabal with stack #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Chain related commands together to minimize temporary file creation * Move cleanup to the end of the RUN command rather than intersperse it between build commands.
* Upgrade cabal-install to 1.22.6
* Removed packages that are not currently on stackage
|
Thanks for the tweet, and sorry for not looking into this. I'll try to find some time to try these changes out and form an opinion on what to do. In the meantime can you please elaborate on the GOAL of your changes? It can either be in the commit messages or here as discussion, but "Replace cabal with stack" is not very convincing if you don't give me any idea on WHY are we doing that. :) As I see it, stack is great, but if it's possible to achieve everything with standard tools, then in an infrastructural project like this, I prefer the standard tools. This way I can keep docker image sizes to the minimal and also be more future proof. Am I mistaken somewhere? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch replaces cabal with stack.
EDIT: after more reflection on this, it's possible I took the stack replacement too far. However, I arranged the commits in this branch so that it would be possible to remove the second-to-last commit and still have some value in the cleanup of the existing
Dockerfile.[Fix #3]