scroll to end now works when user wants to load in chunks. #2324
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrollToEnd as per the README file, it was not working as expected. On scrolling to end in the first case, it is emitting scrollToEnd output event, afterwards, it stopped working. Reasons: Inside ngZone.run(), by docs, it triggers change detection. Not only that. As it will the emit the event. Change Detection will run first. Thus, before assigning _scrollToEndFired true, which is after ngZone.run() method, Angular runs the change detection. Expected, _scrollToEndFired to be true, and then get emitted. If there are any elements triggered, it will set _scrollToEndFired false in detection.
vinayenjapuri
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🎆 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🎆 |
|
@vinayenjapuri I tried your fix. It is not working as expected |
pavankjadda
added
needs reproduction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scrollToEnd as per the README file, it was not working as expected. On scrolling to end in the first case, it is emitting scrollToEnd output event, afterwards, it stopped working.
Reasons:
Inside ngZone.run(), by docs, it triggers change detection. Not only that. As it will the emit the event. Change Detection will run first. Thus, before assigning _scrollToEndFired true, which is after ngZone.run() method, Angular runs the change detection. Expected, _scrollToEndFired to be true, and then get emitted. If there are any elements triggered, it will set _scrollToEndFired false in detection.