Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollToEnd not getting emitted after initial emit. #2323

Closed
vinaymerugu13 opened this issue Dec 5, 2023 · 6 comments
Closed

scrollToEnd not getting emitted after initial emit. #2323

vinaymerugu13 opened this issue Dec 5, 2023 · 6 comments
Assignees
Labels
needs reproduction needs reproducible example stale

Comments

@vinaymerugu13
Copy link

Describe the bug
A clear and concise description of what the bug is.
When I scrolled down in dropdown panel( first time), scrollToEnd is getting emitted. After that, when changes are made in the items list, it stopped getting emitted.
Reproducbile example

Example which reproduces described behaviour

To Reproduce
Steps to reproduce the behavior (if example is not provided):

  1. Go to '...'
  2. Click on 'ng-select'
  3. Scroll down to 'end'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.
Every time scroll reaches its end, scrollToEnd should emit.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • macOS
  • chrome
  • 119.0.6045.199

Additional context
Add any other context about the problem here.
Once you reach the end of dropdown panel, you could see scrollToEnd getting emitted. Then add another 50 same items to the list.
Now scroll to end, you will see scrollToEnd is not emitted.
I have debugged the code and found out that _scrollToEndFired is not getting set to false, after true, upon item changes in _onItemsChange method.
In _fireScrollToEnd, it is getting returned.

@pavankjadda
Copy link
Collaborator

@vinaymerugu13 the link takes me to https://stackblitz.com not your example

@pavankjadda pavankjadda self-assigned this Jan 10, 2024
@pavankjadda pavankjadda added the needs reproduction needs reproducible example label Jan 10, 2024
@vinaymerugu13
Copy link
Author

vinaymerugu13 commented Jan 10, 2024

Example Check this out

@vinaymerugu13
Copy link
Author

vinaymerugu13 commented Jan 10, 2024

#2324 This is the PR I raised after raising the issue. I did it from my different GitHub account. Please checkout. @pavankjadda

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🎆

@github-actions github-actions bot added the stale label Mar 11, 2024
@vinaymerugu13
Copy link
Author

What happened @varnastadeus please update

@github-actions github-actions bot removed the stale label Mar 12, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🎆

@github-actions github-actions bot added the stale label May 11, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reproduction needs reproducible example stale
Projects
None yet
Development

No branches or pull requests

2 participants