Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version #325

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Bump version #325

wants to merge 2 commits into from

Conversation

grst
Copy link
Member

@grst grst commented May 7, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@grst grst requested a review from fmalmeida May 7, 2024 14:20
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit bc22fe8

+| ✅ 171 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-05-07 14:21:44

@maxulysse
Copy link
Member

Linting issue, but you can fix it in a separate PR, tools is getting released soon, so this won't be an issue soon

@grst
Copy link
Member Author

grst commented May 7, 2024

ok, more updates are incoming anyway via #276.
Can you pls merge, I don't have permissions to overrule the checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmalmeida fmalmeida fmalmeida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grst @maxulysse @fmalmeida