New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module bcftools/norm to sarek (in progress) #1483
base: dev
Are you sure you want to change the base?
Conversation
…cfs_with_tbis and fasta.
Still bugged : I'm getting this error but I've added '0' in the 'status' column on my csv input (bam, step variant_calling) |
feat(nf-prov): pin nf-prov to 1.2.2
The error mesage is likely a false flag. We are already in discussion about this with the nf-validation maintainers. I think rather the second half is relevant about the missing tbi. |
Improve cloud testing matrix strategy
|
||
main: | ||
versions = Channel.empty() | ||
|
||
// Normalize vcf-files (added by jcdelmas 240415) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have a section in the readme collecting all contributors for more visibility. Just add yourself there 🙂 : https://github.com/nf-core/sarek/#credits
|
||
main: | ||
versions = Channel.empty() | ||
|
||
// Normalize vcf-files (added by jcdelmas 240415) | ||
GERMLINE_VCFS_NORM(germline_vcfs_with_tbis, fasta) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be causing your error. The germline_vcfs+with_tbis
is defined further down
…cfs_with_tbis and fasta.
resolve issue with spacing Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
|
// Gather versions of all tools used | ||
versions = versions.mix(ADD_INFO_TO_VCF.out.versions) | ||
versions = versions.mix(TABIX_EXT_VCF.out.versions) | ||
versions = versions.mix(GERMLINE_VCFS_NORM.out.versions) | ||
versions = versions.mix(GERMLINE_VCFS_CONCAT.out.versions) | ||
versions = versions.mix(GERMLINE_VCFS_CONCAT.out.versions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
versions = versions.mix(GERMLINE_VCFS_CONCAT.out.versions) | |
versions = versions.mix(GERMLINE_VCFS_CONCAT_SORT.out.versions) |
That seems like a copy-paste bug. Probably my bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I've tried an approach, but now I've got a new error:
Process NFCORE_SAREK:SAREK:POST_VARIANTCALLING:CONCATENATE_GERMLINE_VCFS:GERMLINE_VCFS_NORM
declares 2 input channels but 1 were specified
-- Check script './workflows/sarek/../../subworkflows/local/post_variantcalling/../vcf_concatenate_germline/main.nf' at line: 27 or see '.nextflow.log' file for more details
I've never done groovy, I think I've broken everything or maybe I'm making it too complex ^^'
PR checklist
nf-core lint
).nf-test test tests/ --verbose --profile +docker
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).