Error hangling for the combination of sentieon-dedup and non-sentieon aligner #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
maxulysse
reviewed
Apr 24, 2024
Comment on lines
+126
to
+135
| "if": { | ||
| "properties": { | ||
| "tools": { "pattern": ".*sentieon_dedup.*" } | ||
| } | ||
| }, | ||
| "then": { | ||
| "properties": { | ||
| "aligner": { "const": "sentieon-bwamem" } | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm impressed that this work so easilly.
Well done @asp8200
There was a problem hiding this comment.
Kudos to the nf-schema team 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First merge #1478
Issue : #1480
TO-DO: Update changelog. And sync with #1478 before attempting approval and merge.
PR checklist
nf-core lint).nf-test test tests/ --verbose --profile +docker).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).