Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DRAGMAP with NARFMAP #1358

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Replace DRAGMAP with NARFMAP #1358

wants to merge 3 commits into from

Conversation

edmundmiller
Copy link
Contributor

  • build: DRAGMAP => NARFMAP
  • refactor: DRAGMAP => NARFMAP
  • test: DRAGMAP => NARFMAP

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2023 •
edited

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1e45d73

+| ✅ 146 tests passed       |+
#| ❔  10 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: .github/workflows/awstest.yml
  • pipeline_todos - TODO string in WorkflowSarek.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/sarek/sarek/.github/workflows/awstest.yml
  • template_strings - template_strings

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-10 16:47:17

@edmundmiller edmundmiller self-assigned this Dec 18, 2023
nvnieuwk
nvnieuwk reviewed Dec 19, 2023
View reviewed changes
Copy link

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not a Sarek expert 😁

@maxulysse
Copy link
Member

Looking good

@edmundmiller
Copy link
Contributor Author

I think this needs #1359

@maxulysse
Copy link
Member

I think this needs #1359

I think #1359 needs reviewing

@edmundmiller edmundmiller mentioned this pull request Jan 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvnieuwk nvnieuwk nvnieuwk left review comments

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen FriederikeHanssen will be requested when the pull request is marked ready for review FriederikeHanssen is a code owner

@maxulysse maxulysse Awaiting requested review from maxulysse maxulysse will be requested when the pull request is marked ready for review maxulysse is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edmundmiller @maxulysse @nvnieuwk