Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handle for sentieon-dedup with non-sentieon aligner #1480

Open
asp8200 opened this issue Apr 23, 2024 · 1 comment
Open

Error handle for sentieon-dedup with non-sentieon aligner #1480

asp8200 opened this issue Apr 23, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@asp8200
Copy link
Contributor

asp8200 commented Apr 23, 2024

Description of the bug

There is nothing preventing the user from selecting the tool sentieon_dedup with a non-sentieon aligner, that combination however causes the pipeline to crash.

https://nfcore.slack.com/archives/CGFUX04HZ/p1713879506993449

No user has requested that it should be possible to run such a combination, but the "bug" did pop up during the test done by a user.

Unless the combination is requested by a user, let's just have the pipeline stop with a suitable error message on such a combination of tool and aligner.

Command used and terminal output

No response

Relevant files

No response

System information

No response

@asp8200 asp8200 added the bug Something isn't working label Apr 23, 2024
@asp8200 asp8200 self-assigned this Apr 23, 2024
@asp8200
Copy link
Contributor Author

asp8200 commented Apr 23, 2024

With nf-shema, the problem can be solved by adding the following to nextflow.config :

            "if": {
                "properties": {
                  "tools": { "pattern": ".*sentieon_dedup.*" }
                }
            },
            "then": {
                "properties": {
                  "aligner": { "const": "sentieon-bwamem" }
                }
            }

https://nextflow.slack.com/archives/C056RQB10LU/p1713899757306899?thread_ts=1713799615.441729&cid=C056RQB10LU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant