Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OpenMS version #5585

Merged
merged 4 commits into from May 13, 2024
Merged

Conversation

jonasscheid
Copy link
Contributor

@jonasscheid jonasscheid commented May 10, 2024

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@SPPearce
Copy link
Contributor

You should need to update the snapshots, as they contain the version information.
e.g. nf-core modules test openms/decoydatabase --update

@jonasscheid jonasscheid requested a review from a team as a code owner May 12, 2024 17:39
@jonasscheid jonasscheid requested review from adamrtalbot and removed request for a team May 12, 2024 17:39
@jonasscheid
Copy link
Contributor Author

Thanks for the hint! :)

@SPPearce SPPearce added this pull request to the merge queue May 13, 2024
Merged via the queue into nf-core:master with commit bbcad23 May 13, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants